Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rfc: ember-data | deprecate-non-strict-relationships #739

Conversation

runspired
Copy link
Contributor

@runspired runspired commented Apr 24, 2021

Full Text: Rendered

@runspired runspired added T-deprecation T-ember-data RFCs that impact the ember-data library labels Apr 24, 2021
@belongsTo()
author;

@hasMany({ async: true, inverse: null })
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it vaguely odd for the before to include both strict relationships (for this hasMany) and non-strict (for the belongsTo just above)

Windvis added a commit to lblod/frontend-organization-portal that referenced this pull request Jul 30, 2021
@runspired runspired merged commit 1802ec4 into emberjs:master Apr 13, 2022
@runspired runspired deleted the ember-data/deprecate-non-strict-relationships branch April 13, 2022 23:06
@runspired runspired self-assigned this Jul 31, 2022
runspired added a commit that referenced this pull request Apr 5, 2023
Advance RFC #739 `"EmberData | Deprecate Non Strict Relationships"` to Stage Ready for Release
runspired added a commit that referenced this pull request Jul 28, 2023
Advance RFC #739 `"EmberData | Deprecate Non Strict Relationships"` to Stage Released
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Final Comment Period T-deprecation T-ember-data RFCs that impact the ember-data library
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants