Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning about pnpm #956

Merged
merged 1 commit into from
Jun 24, 2023

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Jun 23, 2023

RFC: emberjs/rfcs#907
Implementation PR: ember-cli/ember-cli#10287
Advancement PR: emberjs/rfcs#932

In this more involved CI setup, having the default pnpm flags https://github.com/NullVoxPopuli/ember-data-resources/actions/runs/5365368548/jobs/9734152943 and it also works

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #956 (abdfb31) into master (81c6107) will increase coverage by 0.17%.
The diff coverage is n/a.

❗ Current head abdfb31 differs from pull request most recent head 3e1d4a2. Consider uploading reports for the commit 3e1d4a2 to get more accurate results

@@            Coverage Diff             @@
##           master     #956      +/-   ##
==========================================
+ Coverage   94.37%   94.54%   +0.17%     
==========================================
  Files          17       17              
  Lines         551      550       -1     
==========================================
  Hits          520      520              
+ Misses         31       30       -1     
Impacted Files Coverage Δ
lib/utils/dependency-manager-adapter-factory.js 91.30% <ø> (+3.80%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review June 23, 2023 20:35
@kategengler kategengler merged commit 00c17a9 into ember-cli:master Jun 24, 2023
@kategengler
Copy link
Member

Thank you!

@NullVoxPopuli NullVoxPopuli deleted the remove-pnpm-warning branch June 24, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants