Skip to content
This repository has been archived by the owner on Mar 22, 2019. It is now read-only.

Port Responsive Header and Footer from Guides #2477

Merged
merged 3 commits into from
Mar 9, 2016

Conversation

ryanlabouve
Copy link
Contributor

I'm working on the 2016 Ember Community Survey landing page. It would be nice to have a responsive header since likely many of the folks viewing the survey on their mobile devices.

I did a quick port of the header from https://guides.emberjs.com/v2.3.0/ across the whole website.

Would something like this be welcomed / helpful?

A few notes:

  • The guides website is using bourbon / neat and the current ember site is not.
  • My port involves taking some of the compiled CSS from the guides to avoid affecting many base styles and creating potentially unwanted visual side effects on the rest of the site.
  • If a more aggressive approach would be preferred (i.e. porting all of the base styles from guides and switching) I'd be happy to assist in any way helpful.

Screenshot:
ember_js_-a_framework_for_creating_ambitious_web_applications

@locks locks self-assigned this Feb 29, 2016
@ryanlabouve
Copy link
Contributor Author

In docs discussion, we talked about:

  • including the footer in this PR
  • Initially, having this opt-in until we can roll the remaining guide styles into the emberjs website.

@ryanlabouve ryanlabouve changed the title Port Responsive Header from Guides — WIP Port Responsive Header from Guides Mar 4, 2016
@ryanlabouve ryanlabouve changed the title Port Responsive Header from Guides Port Responsive Header and Footer from Guides Mar 4, 2016
@ryanlabouve
Copy link
Contributor Author

Here is a GIF showing a screenshot of guides and a screenshot of the website overlaid at the width where they match pixel for pixel.

header-test

They will not line up perfectly on wider screens due to the discussed differences in grid between guides and website.

@ryanlabouve
Copy link
Contributor Author

Updating this PR to incorporate recent changes for header on narrow screens: emberjs/guides#1306

Adding a `.responsive` and `.not-responsive` class to body based
on frontmatter `responsive: true`.

Pages are all not responsive by default. This will allow a more
gradual migration for the website to support responsive.

The responsive viewport is meta tag is also toggled on and
off by the same responsive frontmatter variable per page.
@ryanlabouve
Copy link
Contributor Author

Finished the changes to allow pages to opt-in to the responsive footer and header (with the help of @mixonic).

Attaching a series of GIFs to demonstrate this behavior on responsive vs. non-responsive pages.

Header non-responsive:
fixed-on-non-rwd-page

Header responsive:
responsive-page-header

Footer non-responsive:
fixed-on-non-rwd-page-footer

Footer responsive:
responsive-page-footer

Final pixel-to-pixel comparison (even showing off the stated temporary horizontal spacing difference due to different grids on guides and website):
pixel-perfection

@mixonic
Copy link
Sponsor Member

mixonic commented Mar 5, 2016

@ryanlabouve so very very close. The header between guides and the website when on mobile is a little jank still. A far worse gif than yours:

The header changes height, and the emberjs logo is centered only on the website version. I actually suggest the guides repo change to center the logo.

@ryanlabouve
Copy link
Contributor Author

@mixonic I've made some final adjustments that should resolve this.

Since this is such a high traffic area of the website, I've made another round of comparison GIFs for to show the responsive and non-responsive version of the header compared to guides from the latest commit.

Narrow screens:
narrow-p2p

Medium screen:
medium-p2p

Wide screens (which, as expected due to different grids, has some horizontal shifting):
wide-p2p

mixonic added a commit that referenced this pull request Mar 9, 2016
Port Responsive Header and Footer from Guides
@mixonic mixonic merged commit 8d892e1 into emberjs:master Mar 9, 2016
@mixonic mixonic deleted the rwd-header branch March 9, 2016 22:37
@ryanlabouve ryanlabouve mentioned this pull request Mar 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants