Skip to content
This repository has been archived by the owner on Mar 22, 2019. It is now read-only.

Updates consistent container sizes #2649

Merged
merged 1 commit into from Jul 19, 2016

Conversation

rtablada
Copy link
Contributor

@rtablada rtablada commented Jul 18, 2016

In the midst of the redesign it seems that the container sizes for the page content and header/footer has become inconsistent.

The header footer (and most of the site) uses a 960px container with 1rem of horizontal padding.
However there are a few text containers (most noticeably the .legal-wrapper) which are MUCH smaller.

This is because the .legal-wrapper relied on em units.
Since the base font-size of these areas were reduced to 14px then 60em is no longer the loved 960px but instead comes out to 840px.

On top of this, the padding of the .legal-wrapper container also used 3rem left and right.
This meant that the container was even smaller than the 840px.
The content width of the navbar vs .legal-wrapper is 928px to 756px after padding and everything is done.

This PR brings back consistency in container sizes.

@locks locks merged commit 1266c00 into emberjs:master Jul 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants