We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
version 0.6.0 ember-auto-import: 2.4.0 ember 3.28.0
When I run my fastboot test in browser mode it passes:
When I run it in cli mode it fails with:
Error: Ember CLI FastBoot Testing: We were unable to render /p/abc123. Is your test suite blocking or intercepting HTTP requests
Noticing it's missing the x-fastboot-testing header
x-fastboot-testing
{ connection: 'keep-alive', 'content-length': '22', 'content-type': 'text/html; charset=utf-8', date: 'Tue, 08 Feb 2022 01:10:53 GMT', etag: '\\16-Iz+hV1iVsvp6pCFWupm+jyvhDK8\\', 'keep-alive': 'timeout=5', vary: 'Accept-Encoding', 'x-powered-by': 'Express' }
Any suggestions on what could cause this?
Was able to determine that it fails due to missing request origin header in cli mode at this line: https://github.com/embermap/ember-cli-fastboot-testing/blob/v0.6.0/lib/helpers.js#L42
We need to use a fallback value for CLI mode where req.headers.origin is undefined:
req.headers.origin
ember-cli-fastboot-testing/lib/helpers.js
Line 42 in 7d4c3ed
e.g.
const origin = req.headers.origin || 'http://localhost'; const parsed = new URL(urlToVisit, origin);
The text was updated successfully, but these errors were encountered:
Make lint pass
1d2db53
Successfully merging a pull request may close this issue.
version 0.6.0
ember-auto-import: 2.4.0
ember 3.28.0
When I run my fastboot test in browser mode it passes:
When I run it in cli mode it fails with:
Noticing it's missing the
x-fastboot-testing
headerAny suggestions on what could cause this?
edit 1
Was able to determine that it fails due to missing request origin header in cli mode at this line:
https://github.com/embermap/ember-cli-fastboot-testing/blob/v0.6.0/lib/helpers.js#L42
We need to use a fallback value for CLI mode where
req.headers.origin
is undefined:ember-cli-fastboot-testing/lib/helpers.js
Line 42 in 7d4c3ed
e.g.
The text was updated successfully, but these errors were encountered: