Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for v2 addons, can we remove the addon-shim? #1264

Closed
NullVoxPopuli opened this issue Oct 16, 2022 · 1 comment
Closed

for v2 addons, can we remove the addon-shim? #1264

NullVoxPopuli opened this issue Oct 16, 2022 · 1 comment

Comments

@NullVoxPopuli
Copy link
Collaborator

I don't remember what the purpose of the addon-shim is in v2 addons.

Do we need it?
Since v2 addons are 'just npm packages', can we remove the shim, and 'just rely on auto import' to handle the v2 package, like it would anything off npm?

@ef4
Copy link
Contributor

ef4 commented Oct 17, 2022

It's the only thing that makes them fully work in classic ember-cli apps. There are several things that still aren't "just NPM", like the app-js reexports that remain necessary for most addons until all their users are entirely on gjs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants