Disable compat adapter for ember-inflector >= 4.0.0 (since it is not needed) #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
changed the title
thoov
reviewed
Aug 27, 2021
stefanpenner
force-pushed
the
fix-ember-inflector-compat
branch
from
c487b43
to
64b5d1e
Compare
Newer versions of ember and embroider are not currently compatible, as EmberENV.EXTEND_PROTOTYPES is no longer present. Luckily, the offending code in embroider is the ember-inflector compact-adapter and as of ember-inflector@4.0.0 is no longer needed. To support both pre and post ember-inflector@4.0.0 we conditionally execute the compatibility code when safe & required
stefanpenner
force-pushed
the
fix-ember-inflector-compat
branch
from
64b5d1e
to
3012098
Compare
thoov
approved these changes
Aug 27, 2021
rwjblue
changed the title
rwjblue
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Bugfix release]
EmberENV.EXTEND_PROTOTYPESis not always presentNewer versions of ember and embroider are not currently compatible, as
EmberENV.EXTEND_PROTOTYPESis no longer present.Luckily, the offending code in embroider is the ember-inflector compact-adapter and as of
ember-inflector@4.0.0is no longer needed.To support both pre and post
ember-inflector@4.0.0we conditionally execute the compatibility code when safe & requiredThis fix is blocking: ember-cli/ember-cli#9597