Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable compat adapter for ember-inflector >= 4.0.0 (since it is not needed) #948

Merged
merged 2 commits into from
Aug 27, 2021
Merged

Disable compat adapter for ember-inflector >= 4.0.0 (since it is not needed) #948

merged 2 commits into from
Aug 27, 2021

Commits on Aug 27, 2021

  1. [Bugfix release] EmberENV.EXTEND_PROTOTYPES is not always present 

    Newer versions of ember and embroider are not currently compatible, as EmberENV.EXTEND_PROTOTYPES is no longer present.
Luckily, the offending code in embroider is the ember-inflector compact-adapter and as of ember-inflector@4.0.0 is no longer needed.

To support both pre and post ember-inflector@4.0.0 we conditionally execute the compatibility code when safe & required
    @stefanpenner
    stefanpenner committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    3ce0dba View commit details
    Browse the repository at this point in the history

  2. This folder should never be committed

    @stefanpenner
    stefanpenner committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    3012098 View commit details
    Browse the repository at this point in the history