You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current setting how the different fitting interfaces (batch, minibatch, stream) are implemented has several problems:
The variable naming is not consistent / misleading but cannot be changed (e.g. the streaming method also processes minibatches, but the corresponding kwargs cannot be renamed as such because the higher level fit function uses the names to differentiate between the methods).
Switching between the different functions is not straightforward (e.g. it requires adding an additional algorithm kwarg), which requires if-else logic in the tests.
A potential solution might be to create a higher-level abstract Algorithm class that has the current MiniBatchAlgorithm as a subclass together with others that cover the batch and streaming scenario.
The text was updated successfully, but these errors were encountered:
The current setting how the different fitting interfaces (batch, minibatch, stream) are implemented has several problems:
fit
function uses the names to differentiate between the methods).algorithm
kwarg), which requires if-else logic in the tests.A potential solution might be to create a higher-level abstract
Algorithm
class that has the currentMiniBatchAlgorithm
as a subclass together with others that cover the batch and streaming scenario.The text was updated successfully, but these errors were encountered: