Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign fit interfaces #61

Open
AdrianSosic opened this issue Nov 12, 2021 · 0 comments
Open

Redesign fit interfaces #61

AdrianSosic opened this issue Nov 12, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@AdrianSosic
Copy link
Collaborator

The current setting how the different fitting interfaces (batch, minibatch, stream) are implemented has several problems:

  • The variable naming is not consistent / misleading but cannot be changed (e.g. the streaming method also processes minibatches, but the corresponding kwargs cannot be renamed as such because the higher level fit function uses the names to differentiate between the methods).
  • Switching between the different functions is not straightforward (e.g. it requires adding an additional algorithm kwarg), which requires if-else logic in the tests.

A potential solution might be to create a higher-level abstract Algorithm class that has the current MiniBatchAlgorithm as a subclass together with others that cover the batch and streaming scenario.

@AdrianSosic AdrianSosic added the enhancement New feature or request label Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant