Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix learning rule: should sub-pools only get credit if they were the ones that drove Gating #154

Open
rcoreilly opened this issue Feb 2, 2023 · 0 comments

Comments

@rcoreilly
Copy link
Member

Previously, we only learned for subPools that got above the gating threshold:

      prjnparams.go:369:
	if subPool.Gated.IsTrue() {
		dtr = rn.SpkMax * sn.CaSpkD // we will get the credit later at time of US
	}

However, this does not really make sense for the NoGo case where there is not a strong pool-level logic..

here's the comment:

	// let's not worry about giving credit only to the sub-pool for now
	// if we need to do this later, we can add a different factor for
	// D2 (NoGo) vs D1 (Go) -- the NoGo case should *not* care about subpools
	// in any case.  Probably the Go case can not care too.

this ticket is just a reminder to remember this and revisit should some kind of parasitic activity develop in the Go layers as a result!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant