Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TD algorithm not reflecting negative externally-delivered reinforcements (i.e., NegPV) #11

Open
thazy opened this issue Apr 27, 2020 · 0 comments

Comments

@thazy
Copy link

thazy commented Apr 27, 2020

In td.go file of pbwm package, the function on the RewInteg layer does not reflect NegPV values clamped on the Rew layer. Note how plus phase Act takes only nrn.Ge value as its current Reward value, which presumably reflects the net input fm Reward layer only and Ge is positive-rectified? Here is the relevant function:

func (ly *TDRewIntegLayer) ActFmG(ltime leabra.Time) {
rply, _ := ly.RewPredLayer()
if rply == nil {
return
}
rpActP := rply.Neurons[0].ActP
rpAct := rply.Neurons[0].Act
for ni := range ly.Neurons {
nrn := &ly.Neurons[ni]
if nrn.IsOff() {
continue
}
if ltime.Quarter == 3 { // plus phase
nrn.Act = nrn.Ge + ly.RewInteg.Discount
rpAct
} else {
nrn.Act = rpActP // previous actP
}
}
}

@thazy thazy changed the title TD algorithm not reflected negative externally-delivered reinforcements (i.e., NegPV) TD algorithm not reflecting negative externally-delivered reinforcements (i.e., NegPV) Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant