Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly wrap dkim header. #30

Closed
wants to merge 1 commit into from
Closed

Conversation

wjywbs
Copy link

@wjywbs wjywbs commented May 27, 2020

This change has been validated by sending large email campaigns.

This change has been validated by sending large email campaigns.
@codecov-commenter
Copy link

Codecov Report

Merging #30 into master will decrease coverage by 1.40%.
The diff coverage is 46.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   66.30%   64.90%   -1.41%     
==========================================
  Files           7        7              
  Lines         837      869      +32     
==========================================
+ Hits          555      564       +9     
- Misses        213      233      +20     
- Partials       69       72       +3     
Impacted Files Coverage Δ
dkim/header.go 75.63% <43.90%> (-17.48%) ⬇️
dkim/sign.go 68.58% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4c8736...c74373c. Read the comment docs.

@emersion
Copy link
Owner

Thanks for taking the time to write a patch, but this has been fixed in #29

@emersion emersion closed this May 28, 2020
@wjywbs
Copy link
Author

wjywbs commented May 28, 2020

Thanks. By the way, this fixes the h= wrapping as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants