Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix creating index in mysql. #31

Merged
merged 1 commit into from
May 27, 2020
Merged

Fix creating index in mysql. #31

merged 1 commit into from
May 27, 2020

Conversation

wjywbs
Copy link
Contributor

@wjywbs wjywbs commented May 27, 2020

MySQL does not support "CREATE INDEX IF NOT EXISTS".

MySQL does not support "CREATE INDEX IF NOT EXISTS".
@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #31 into dev will decrease coverage by 0.19%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##              dev      #31      +/-   ##
==========================================
- Coverage   55.56%   55.36%   -0.20%     
==========================================
  Files          21       21              
  Lines        3387     3399      +12     
==========================================
  Hits         1882     1882              
- Misses       1173     1183      +10     
- Partials      332      334       +2     
Impacted Files Coverage Δ
sql.go 74.52% <20.00%> (-1.34%) ⬇️

@foxcpp foxcpp merged commit 3c4815a into foxcpp:dev May 27, 2020
@foxcpp
Copy link
Owner

foxcpp commented May 27, 2020

Thanks! Honest question though, how hard it would be to actually switch from MySQL to MariaDB? If my understanding is correct, MariaDB can act as a drop-in replacement.

@foxcpp
Copy link
Owner

foxcpp commented May 27, 2020

P.S. If you are doing this PR to use MySQL with maddy, the change you made will make its way into pending 0.3 release that is currently being blocked by this issue: foxcpp/maddy#226

You can use it now by cloning maddy repo, running go get github.com/foxcpp/go-imap-sql@dev and then ./build.sh as usual.

@wjywbs
Copy link
Contributor Author

wjywbs commented May 27, 2020

That comes down to the preferences of the DBAs.

I have a fix for foxcpp/maddy#226 as well: emersion/go-msgauth#30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants