Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WL_OUTPUT_SUBPIXEL_NONE should disable subpixel #258

Closed
imyxh opened this issue Apr 18, 2020 · 2 comments · Fixed by #261
Closed

WL_OUTPUT_SUBPIXEL_NONE should disable subpixel #258

imyxh opened this issue Apr 18, 2020 · 2 comments · Fixed by #261

Comments

@imyxh
Copy link

imyxh commented Apr 18, 2020

See sway/#5228: Mako currently treats the WL_OUTPUT_SUBPIXEL_NONE setting with the default subpixel orientation. As such, there is no way to disable subpixel on Mako (i.e. set it to grayscale).

Link to relevant code (thanks to progandy).

I personally strongly dislike the colored fringes created by all types of subpixel rendering and would really appreciate a way to switch it to grayscale/gradient antialiasing. Note that I have also set grayscale in fontconfig, which Mako doesn't respect:

$ file /etc/fonts/conf.d/10-no-sub-pixel.conf
/etc/fonts/conf.d/10-no-sub-pixel.conf: symbolic link to ../conf.avail/10-no-sub-pixel.conf
@vilhalmer
Copy link
Collaborator

I opened #261 to probably fix this, but because I'm not super familiar with the configuration around this I haven't tested it thoroughly yet. I tried disabling subpixel on one of my outputs but couldn't see a difference so I'm not sure it actually worked. @imyxh would you mind pulling the patch from that pull request to see if it has the correct behavior, or if there are more areas we need to touch?

I'll also try to test some stuff before I remove the draft marker but I'm currently consumed by something else.

@vilhalmer
Copy link
Collaborator

Ah, turns out it's just that none of my other apps obey the setting. Mako definitely picked it up:
screenshot_2020-04-19-110342

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants