-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Chrome {dev,beta,stable} and Chromium crash on Desktop Sharing on xdpw-git #205
Comments
@grulja: This looks to my like renegotiation is tripping sth. in chromium. |
@kriive I can confirm this happening with chromium native and with the flatpak version. |
I can confirm OBS (from master, with |
On my system I don't get any crashes in 101.0.4951.54 (Official Build) Arch Linux (64-bit) but the shared image is corrupted. My graphics card (RX570) does not support explicit modifiers. There is no problem in OBS. Firefox does not support DMABUF screen sharing. Running with RADEON_DEBUG=nodcc did not fix the issue. Edit: Forcing GBM_BO_USE_LINEAR fixes the issue. |
@mahkoh You only have one gpu and the image was still corrupt without the |
Correct. |
I'm trying to reproduce in Sway with latest xdg-desktop-portal-wlr from git, but it doesn't even get to settle the format:
and it keeps repeating last two lines. This is with NVIDIA proprietary driver. Edit: same happens with OBS studio |
@columbarius I see that xdg-desktop-portal-wlr uses the first render node it can find, but that doesn't necessarily be the one used by the compositor. I had same issue in WebRTC, where I used the first render node, but DMA-BUFs provided to me might be created by a different one. This will be case in multi-GPU setup, like I have for example with Intel + Nvidia. See https://webrtc-review.googlesource.com/c/src/+/250661 for reference. And indeed, using the other render node makes it to finally settle on the format and reproduce the issue. I will keep investigating now on my (WebRTC) side. |
The crash should be fixed with flathub/org.chromium.Chromium#228. There should be a test build available soon. |
Great!. Thanks for testing. |
@kriive I tested xdpw master with current chromium on flatpack and it worked. Can we close this? |
all works for me too now with ungoogled-chromium/chromium/chrome flatpak 👍👍 |
Yes, of course! Thanks to everyone involved in the fix! |
I am on Arch Linux. I have installed xdpw via the AUR package
xdg-desktop-portal-wlr-git
. The issue seems to disappear if I install thexdg-desktop-portal-wlr
release (on pacman).Using the latest Firefox I can share my desktop without issues (using https://mozilla.github.io/webrtc-landing/gum_test.html).
Different story when trying the same on Chromium-based browsers.
I've tried with:
with the same result:
I attach the
/lib64/xdg-desktop-portal-wlr -l DEBUG -r
output here.debug.txt
Let me know if you need other info or debug stuff.
The text was updated successfully, but these errors were encountered: