Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error on unmounting ReactAudioPlayer component #15

Closed
emibcn opened this issue Mar 12, 2021 · 1 comment
Closed

Error on unmounting ReactAudioPlayer component #15

emibcn opened this issue Mar 12, 2021 · 1 comment
Assignees
@emibcn
Labels
bug Something isn't working

Comments

@emibcn
Copy link
Owner

emibcn commented Mar 12, 2021

The component does not removes event listeners on unmount, which leads to its execution when unmounting in some situations.

Solution

Remove component's event listeners on unmount: justinmc/react-audio-player#105
@emibcn emibcn added the bug Something isn't working label Mar 12, 2021
@emibcn emibcn self-assigned this Mar 12, 2021
@emibcn emibcn mentioned this issue Mar 23, 2021
Closed
@emibcn
Copy link
Owner Author

emibcn commented Apr 21, 2021 •
edited
Loading

Fixed dependency issue justinmc/react-audio-player#104

@emibcn emibcn closed this as completed Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emibcn emibcn

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emibcn