Fix crash on request_animation_frame
when destroying web runner
#4169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, any frames in flight (
requestAnimationFrame
) on web were not being cancelled (cancelAnimationFrame
) whenWebRunner::destroy
was called. If a user calleddestroy
, then immediately removed the canvas from the DOM, eframe could panic with a "failed to find (canvas) element by id" error message.This PR changes two things:
canvas_id
1WebRunner
andcancelAnimationFrame
is called on it inside ofWebRunner::destroy
2Footnotes
The WebGL/WGPU backends were already holding onto the canvas (and associated GPU context), so the change is just converting all the
get_element_by_id
lookups to retrieve the canvas from the web runner handle. ↩There is only ever one frame in flight, so we store it directly as a scalar field. ↩