Prevent visual glitch when shadow blur width is very high #4245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
emilk
added a commit
that referenced
this pull request
Mar 29, 2024
## egui changelog ### 🐛 Fixed * Fix visual glitch on the right side of highly rounded rectangles [#4244](#4244) * Prevent visual glitch when shadow blur width is very high [#4245](#4245) * Fix `InputState::any_touches` and add `InputState::has_touch_screen` [#4247](#4247) * Fix `Context::repaint_causes` returning no causes [#4248](#4248) * Fix touch-and-hold to open context menu [#4249](#4249) * Hide shortcut text on zoom buttons if `zoom_with_keyboard` is false [#4262](#4262) ### 🔧 Changed * Don't apply a clip rect to the contents of an `Area` or `Window` [#4258](#4258) ## eframe changelog * Web: repaint if the `#hash` in the URL changes [#4261](#4261) * Add web support for `zoom_factor` [#4260](#4260) (thanks [@justusdieckmann](https://github.com/justusdieckmann)!) --------- Co-authored-by: Justus Dieckmann <45795270+justusdieckmann@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment in the code explains it well, but the short of it is this: we can't handle a shadow blur width larger than the shadow rectangle, so we need to clamp the blur. This means smaller things will cast shadows with a smaller blur width, but that's better than having visual glitches.