Add web support for zoom_factor
#4260
Conversation
|
Thank you very much for the library! I did my first bigger project in rust and am really happy with it, especially the ease with which one can create both a native and web application. My prof had some difficulty reading the text, and I can see how one might have problems, especially with the moderate text contrast in dark mode. So I created this PR because I would like to enlarge the website a bit by default |
|
The intent of the current behavior is that the web browser is in charge of the zoom-factor/pixels-per-point. If you launch a native egui app and press cmd-plus, you will zoom in, because egui catches that command and adjust the zoom factor. Do you want to be able to zoom an egui app independently of the browsers setting? |
|
Exactly, I don't want to override the browsers zoom level, but I would like to be able to adjust the zoom level of the application programmatically |
emilk
added
web
|
Makes sense - thanks for the PR! |
Before, when setting the `zoom_factor`, the website was already enlarged, but the zoom was ignored when calculating the logical window size and mouse position, causing an offset between the actual cursor and selected elements. That is addressed here --------- Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
## egui changelog ### 🐛 Fixed * Fix visual glitch on the right side of highly rounded rectangles [#4244](#4244) * Prevent visual glitch when shadow blur width is very high [#4245](#4245) * Fix `InputState::any_touches` and add `InputState::has_touch_screen` [#4247](#4247) * Fix `Context::repaint_causes` returning no causes [#4248](#4248) * Fix touch-and-hold to open context menu [#4249](#4249) * Hide shortcut text on zoom buttons if `zoom_with_keyboard` is false [#4262](#4262) ### 🔧 Changed * Don't apply a clip rect to the contents of an `Area` or `Window` [#4258](#4258) ## eframe changelog * Web: repaint if the `#hash` in the URL changes [#4261](#4261) * Add web support for `zoom_factor` [#4260](#4260) (thanks [@justusdieckmann](https://github.com/justusdieckmann)!) --------- Co-authored-by: Justus Dieckmann <45795270+justusdieckmann@users.noreply.github.com>
Before, when setting the
zoom_factor, the website was already enlarged, but the zoom was ignored when calculating the logical window size and mouse position, causing an offset between the actual cursor and selected elements. That is addressed here