Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow user to use React elements also inside toaster #380

Closed
wants to merge 4 commits into from

Conversation

borisadamyan
Copy link
Contributor

Issue 😱:

Closes #378

allow the user to use React elements within the toaster description section. βœ…

Screenshots/Videos πŸŽ₯:

Screenshot 2024-03-21 at 09 51 00
Screenshot 2024-03-21 at 09 54 50

Copy link

vercel bot commented Mar 21, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
sonner βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Mar 25, 2024 8:58am

@macalinao
Copy link

Looking forward to this getting merged.

@borisadamyan
Copy link
Contributor Author

Looking forward to this getting merged.
Yeah. Let's wait for @emilkowalski to approve.

@jose-donato
Copy link

amazing!

looking forward to this one as well πŸ‘

@peetzweg
Copy link
Contributor

Whoops implemented this quickly as well. However, I also added some tests to prevent this happening again in the future. Maybe worthwhile bringing them in as well? #387

@borisadamyan
Copy link
Contributor Author

Looking forward to this getting merged.

Yeah. Let's wait for @emilkowalski to approve.

Just for reminder @emilkowalski

@emilkowalski
Copy link
Owner

Fixed in #387

@jose-donato
Copy link

jose-donato commented Apr 10, 2024

Fixed in #387

amazing. is a new version going to be released with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using a React element for description displays [object Object]
6 participants