Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recent changes to plot.phylo / phylogram.plot have side effext #19

Closed
KlausVigo opened this issue Jun 26, 2021 · 1 comment
Closed

recent changes to plot.phylo / phylogram.plot have side effext #19

KlausVigo opened this issue Jun 26, 2021 · 1 comment

Comments

@KlausVigo
Copy link
Contributor

Hi Emmanuel and Martin (@emmanuelparadis, @ms609),
the recent changes you made to plot.phylo and phylogram.plot seem to cause side effects.
I'll try to fix this but you want to check if there are other packages affected.

I get an error during R check with github actions: 
> checking examples ... ERROR
Error:   Running examples in ‘phangorn-Ex.R’ failed
  The error most likely occurred in:
  
  > base::assign(".ptime", proc.time(), pos = "CheckExEnv")
  > ### Name: cladePar
  > ### Title: Utility function to plot.phylo
  > ### Aliases: cladePar
  > ### Keywords: plot
  > 
  > ### ** Examples
  > 
  > 
  > tree <- rtree(10)
  > plot(tree)
  > nodelabels()
  > x <- cladePar(tree, 12)
  > cladePar(tree, 18, "blue", "blue", x=x, plot=TRUE)
  Error in segments(x0v, y0v, x0v, y1v, col = color.v, lwd = width.v, lty = lty.v) : 
    invalid line type: must be length 2, 4, 6 or 8
  Calls: cladePar -> plot -> plot.phylo -> phylogram.plot -> segments
  Execution halted

Cheers,
Klaus

@emmanuelparadis
Copy link
Owner

Hi Klaus,
Thanks for the fix! The details can be found at ?par in the section "Line Type Specification". I have accepted your PR.
Cheers,
Emmanuel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants