Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onlyoffice module seems to be broken #6

Closed
nikp123 opened this issue Apr 17, 2023 · 12 comments
Closed

onlyoffice module seems to be broken #6

nikp123 opened this issue Apr 17, 2023 · 12 comments

Comments

@nikp123
Copy link
Contributor

nikp123 commented Apr 17, 2023

image
image

@nikp123
Copy link
Contributor Author

nikp123 commented Apr 17, 2023

@nikp123
Copy link
Contributor Author

nikp123 commented Apr 17, 2023

@nikp123
Copy link
Contributor Author

nikp123 commented Apr 17, 2023

didnt work because onlyoffice was built from binary, but they've thankfully added a CUSTOM_PATH to play around with ONLYOFFICE/core@68582b6

@nikp123
Copy link
Contributor Author

nikp123 commented Apr 17, 2023

bummer, it doesn't work with symlinks. though, you could use something like this in order to get fonts to work

@nikp123
Copy link
Contributor Author

nikp123 commented Apr 17, 2023

worked a bad solution, but it's a solution:

  nixpkgs.overlays = [
    ( self: super: {
      onlyoffice-bin = super.onlyoffice-bin.overrideAttrs (old: {
        preFixup = (old.preFixup or "") + ''
          gappsWrapperArgs+=(
            --set CUSTOM_FONTS_PATH "${pkgs.microsoft-fonts}/share/fonts/TTF"  # or whatever font you desire to use
          )
        '';
      });
    })
  ];

@emmanuelrosa
Copy link
Owner

Yes, ONLYOFFICE has a known issue (which I've reported) when /usr/share/fonts contains symlinks. The ONLYOFFICE module uses the code from fonts.fontDir.enable but I copy the fonts instead of creating symlinks to them.

I'm unable to reproduce your error. Can you show me the build log?

@nikp123
Copy link
Contributor Author

nikp123 commented Apr 27, 2023

Yes, ONLYOFFICE has a known issue (which I've reported) when /usr/share/fonts contains symlinks. The ONLYOFFICE module uses the code from fonts.fontDir.enable but I copy the fonts instead of creating symlinks to them.

I'm unable to reproduce your error. Can you show me the build log?

The log is quite boring, as it's just a simple "folder not found" error.
log.txt

@nikp123
Copy link
Contributor Author

nikp123 commented Apr 27, 2023

I imported your module as a flake, added this to my nixOS modules: erosanix.nixosModules.onlyoffice

And invoked programs.onlyoffice.enable = true;

@emmanuelrosa
Copy link
Owner

I pushed an update that I think will fix it.

The error message is correct in that the given path is not a directory; It's a symlink. The update copies the icons instead of using a symlink. There must be a difference between how that's handled on NixOS 22.11 and NixOS master.

@nikp123
Copy link
Contributor Author

nikp123 commented Apr 27, 2023

image

Uh, yeah, more bugs to crush unfortunately.

@emmanuelrosa
Copy link
Owner

OK, I see that the package on NixOS 21.11 doesn't have icons. I pushed an update that should work around that.

@nikp123
Copy link
Contributor Author

nikp123 commented Apr 28, 2023

Works perfectly now, thank you.

@nikp123 nikp123 closed this as completed Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants