Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chemical identifiers #274

Closed
eibar-flores opened this issue Feb 27, 2024 · 6 comments
Closed

Add chemical identifiers #274

eibar-flores opened this issue Feb 27, 2024 · 6 comments

Comments

@eibar-flores
Copy link

Is it possible to add additional chemical identifiers? Some widely used are not yet supported by emmo.

  • SMILES (isA ChemicalNomenclature): http://opensmiles.org/opensmiles.html

  • InChI Key (isA IUPACNomenclature): a hashed version of the full InChI (using the SHA-256 algorithm, designed to allow for easy web searches of chemical compounds.

@jesper-friis
Copy link
Contributor

Would it make sense to add two new annotation properties for them in the chemistry module?

@eibar-flores
Copy link
Author

Would it make sense to add two new annotation properties for them in the chemistry module?

It is a possibility, yes. However, given InChI is already defined in EMMO, wouldn't it be confusing to define InChI Key and SMILES in a different module?

@jesper-friis
Copy link
Contributor

I was thinking about the chemistry module in EMMO, the same module in which InChI is defined.

@jesper-friis
Copy link
Contributor

Where you thinking about something like this: #275

@eibar-flores
Copy link
Author

Where you thinking about something like this: #275

Excellent, this works. Thanks for addressing it so quickly!

@jesper-friis
Copy link
Contributor

We will review the PR in the EMMO dev. meeting on Thursday. Then it might be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants