Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes conflicting in pull request #8

Open
cpavloud opened this issue Jul 11, 2024 · 4 comments
Open

Changes conflicting in pull request #8

cpavloud opened this issue Jul 11, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@cpavloud
Copy link
Contributor

cpavloud commented Jul 11, 2024

I propose these changes to the run-information-batch-001.csv, run-information-batch-002.csv, run-information-batch-001_column-descriptions.csv and run-information-batch-002_column-descriptions.csv:

  1. The proper name of the parameter in the https://github.com/emo-bon/sequencing-data/blob/main/shipment/batch-002/run-information-batch-002_column-descriptions.csv is "dna_quant", not "dna_quantity_after_extraction"
  2. The proper name of the parameter in the https://github.com/emo-bon/sequencing-data/blob/main/shipment/batch-001/run-information-batch-001_column-descriptions.csv is "dna_quant", not "dna_quantity_after_extraction"
  3. "paired" should be "PAIRED" (this is the appropriate value for the submission to ENA
  4. The metadata full term "analysis" was repeated twice. Actually, what is term 20 is the "library_source" field that ENA requires for submission of reads.
  5. "seq_meth" is actually the "instrument_model" in the ENA reads submission
  6. Extra terms should be added: extraction_blank,pcr_blank_1,pcr_blank_2
    Those terms should be defined as:
    31,extraction_blank,correspoding extraction blank sequencing reads filename,Filename given by the sequencing centre to the sequencing reads produced by the extraction blank included in the same sequencing run as the sample,text,CDX_ABMLOSTA_1_1_HGVH5DRX3.UDI363,Sequencing,Genoscope; Ioulia Santi,Optional (O),,
    32,pcr_blank_1,correspoding 1st pcr blank sequencing reads filename,Filename given by the sequencing centre to the sequencing reads produced by the 1st PCR sequencing blank included in the same sequencing run as the sample,text,CEB_DCXOSTA_1_1_HGVH5DRX3.UDI363,Sequencing,Genoscope; Ioulia Santi,Optional (O),,
    33,pcr_blank_2,correspoding 2nd pcr blank sequencing reads filename,Filename given by the sequencing centre to the sequencing reads produced by the 2nd PCR sequencing blank included in the same sequencing run as the sample,text,CEB_DCYOSTA_1_1_HGVH5DRX3.UDI364,Sequencing,Genoscope; Ioulia Santi,Optional (O),,

@melinalou

@cpavloud cpavloud added the enhancement New feature or request label Jul 11, 2024
@cpavloud
Copy link
Contributor Author

@bulricht

@kmexter
Copy link
Contributor

kmexter commented Oct 24, 2024

1-5 I can do - will inform bram when done
6 I don't understand - what you wrote is to go into the two descriptions files, but these columns do not exist in the main files so why add these? Are these columns that will be added to future batches/to these batches soon?

@cpavloud
Copy link
Contributor Author

They should be added in the future.
The PCR blanks are especially relevant for the metabarcoding samples.

@kmexter
Copy link
Contributor

kmexter commented Oct 25, 2024

OK, so then we will add those columns when we have info to put in them. We will keep this issue alive until then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants