Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: N+1 queries for notifications API #196

Closed
emoss08 opened this issue Jan 3, 2024 · 1 comment
Closed

fix: N+1 queries for notifications API #196

emoss08 opened this issue Jan 3, 2024 · 1 comment
Assignees
@emoss08
Labels
backend Change to backend application bug Something isn't working included in next release Enhancement will be deployed in the next release

Comments

@emoss08
Copy link
Owner

emoss08 commented Jan 3, 2024 •
edited
Loading

Currently their is a huge N+1 query problem due to using django-notifications-hq The core functionality of this library is great, however the API endpoint that is given with it is not optimized what so ever. I will need to build my own endpoint that fetches all of the primary data.

Current State:

image

Future State:

This should have the ability to be reduced to 1 or 2 queries. Using select related and prefetches.
@emoss08 emoss08 added bug Something isn't working backend Change to backend application labels Jan 3, 2024
@emoss08 emoss08 self-assigned this Jan 3, 2024
@emoss08 emoss08 added the included in next release Enhancement will be deployed in the next release label Feb 27, 2024
@repo-ranger Repo Ranger
Copy link

repo-ranger bot commented Feb 27, 2024

Congratulations! This issue has been included in the next release! Closing in 15 seconds . . .

@repo-ranger repo-ranger bot closed this as completed Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emoss08 emoss08

Labels
backend Change to backend application bug Something isn't working included in next release Enhancement will be deployed in the next release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emoss08