Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LMS Rails 5.0 Prework - Address deprecation: passing string to define callback #7564

Merged
merged 1 commit into from
May 4, 2021

Conversation

brendanshean
Copy link
Member

@brendanshean brendanshean commented May 3, 2021

WHAT

This PR addresses a Rails 5 deprecation for passing strings to define callbacks.

WHY

In order to upgrade to Rails 5 need to address deprecations

HOW

Update the after_commit blocks to use class method calls instead of strings.

Notion Card Links

https://www.notion.so/quill/Upgrade-LMS-to-Rails-5-0-b742cd5e1764427d8670944d50e2a3e3

PR Checklist Your Answer
Have you added and/or updated tests? No. There is no new functionality here, just a refactoring fo the upgrade.
Have you deployed to Staging? Not yet - deploying now!
Self-Review: Have you done an initial self-review of the code below on Github? YES
Design Review: If applicable, have you compared the coded design to the mockups? Yes

@brendanshean brendanshean changed the title Address deprecation: passing string to define callback LMS Rails 5.0 Upgrade - Address deprecation: passing string to define callback May 3, 2021
@brendanshean brendanshean changed the title LMS Rails 5.0 Upgrade - Address deprecation: passing string to define callback LMS Rails 5.0 Prework - Address deprecation: passing string to define callback May 3, 2021
@brendanshean brendanshean temporarily deployed to empirical-grammar-staging May 3, 2021 14:05 Inactive
@brendanshean brendanshean merged commit 1d5a33f into develop May 4, 2021
@delete-merged-branch delete-merged-branch bot deleted the bs-fix-strings-used-to-define-callbacks branch May 4, 2021 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants