Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoints #12

Merged
merged 9 commits into from
Nov 6, 2017
Merged

Add endpoints #12

merged 9 commits into from
Nov 6, 2017

Conversation

aquateen
Copy link
Contributor

@aquateen aquateen commented Nov 6, 2017

Adds the following endpoints:

  • /candidates/:id/comments
  • /candidates/:id/disqualify
  • /candidates/:id/revert
  • /candidates/:id/copy
  • /candidates/:id/relocate
  • /candidates/:id/move
  • /candidates/:id/ratings

Chris Johnson added 9 commits November 6, 2017 00:43
The fixtures are the same and the endpoints are similar, but I separated
them out in order to avoid confusion in using the same fixture.
Was getting uninitialized constant error for forwardable gem.
@coveralls
Copy link

Coverage Status

Coverage increased (+4.4%) to 96.154% when pulling 4ae08fb on aquateen:add_endpoints into 8b01ebd on emq:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+4.4%) to 96.154% when pulling 4ae08fb on aquateen:add_endpoints into 8b01ebd on emq:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+4.4%) to 96.154% when pulling 4ae08fb on aquateen:add_endpoints into 8b01ebd on emq:master.

@rwojsznis
Copy link
Owner

Hello @aquateen! Huge thanks for this PR! ❤️

I'm wondering about that member_id.to_s calls - docs are stating it have to be a string https://workable.readme.io/docs/comment-on-candidate - I don't really like automagically casting anything in API clients (bite me in the a$$ few times already) so let me update this after the merge :).

If you could tell me when workable can return 2xx code with an empty body - that also would be great to know.

I will unify the coding style a little bit as well, update readme and release the new version (within like ~2 days I think)

@rwojsznis rwojsznis merged commit 9d18e68 into rwojsznis:master Nov 6, 2017
@aquateen
Copy link
Contributor Author

aquateen commented Nov 6, 2017

  1. That sounds good re: member_id
  2. The post requests seem to a bit inconsistent with the responses. Some endpoints return an empty body, others don't. Also different successful status codes.

Thank YOU for this gem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants