Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): add engines #1425

Merged
merged 1 commit into from Sep 27, 2023
Merged

feat(deps): add engines #1425

merged 1 commit into from Sep 27, 2023

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Sep 20, 2023

What is the current behavior?

No warning if installed on old outdated nodejs.

Issue Number

none

What is the new behavior?

Not installable on old outdated nodejs without extra ignore flag.

Does this PR introduce a breaking change?

  • Yes
  • No

Removes nodejs <16.

Specific Instructions

none

Other information

none

@ysfscream ysfscream requested review from Red-Asuka, ysfscream and ni00 and removed request for Red-Asuka September 21, 2023 06:10
@ysfscream ysfscream added dependencies Pull requests that update a dependency file chore Changes in build tools or dependent packages labels Sep 21, 2023
web/package.json Outdated Show resolved Hide resolved
@ysfscream ysfscream merged commit 56f5afc into emqx:main Sep 27, 2023
6 checks passed
@ysfscream
Copy link
Member

@Rotzbua Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes in build tools or dependent packages dependencies Pull requests that update a dependency file
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants