Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): add windows build ci #1487

Merged
merged 4 commits into from
Nov 10, 2023
Merged

chore(ci): add windows build ci #1487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bce7814
chore(ci): add windows build ci
ysfscream Nov 10, 2023
fee207f
fix(ci): fix path in vite.config.ts
ysfscream Nov 10, 2023
a09ef9d
fix(ci): update electron-builder.yml for Windows installer
ysfscream Nov 10, 2023
1c1c1d1
fix(ci): update executable and artifact names in
ysfscream Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions .github/workflows/build_desktop.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ jobs:

strategy:
matrix:
# os: [ubuntu-latest, macos-latest, windows-latest]
os: [ubuntu-latest, macos-latest]
os: [ubuntu-latest, macos-latest, windows-latest]

steps:
- name: Check out Git repository
Expand Down Expand Up @@ -53,9 +52,9 @@ jobs:
if: matrix.os == 'macos-latest'
run: pnpm run build:mac

# - name: Build Win
# if: matrix.os == 'windows-latest'
# run: pnpm run build:win
- name: Build Win
if: matrix.os == 'windows-latest'
run: pnpm run build:win

- name: release
uses: softprops/action-gh-release@v1
Expand All @@ -68,7 +67,6 @@ jobs:
apps/desktop/dist/*.AppImage
apps/desktop/dist/*.snap
apps/desktop/dist/*.deb
apps/desktop/dist/*.rpm
apps/desktop/dist/*.tar.gz
apps/desktop/dist/*.yml
apps/desktop/dist/*.blockmap
Expand Down
28 changes: 14 additions & 14 deletions apps/desktop/electron-builder.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,20 +12,20 @@ files:
asarUnpack:
- resources/**

# win:
# executableName: ${productName}
# artifactName: ${productName}-Setup-${version}-${arch}.${ext}
# target:
# - target: nsis
# arch: [x64, ia32, arm64]
# nsis:
# oneClick: false
# allowElevation: true
# allowToChangeInstallationDirectory: true
# createStartMenuShortcut: true
# shortcutName: ${productName}
# uninstallDisplayName: ${productName}
# createDesktopShortcut: always
win:
executableName: MQTTX
target:
- target: nsis
arch: [x64, ia32, arm64]
nsis:
artifactName: MQTTX-Setup-${version}-setup.${ext}
shortcutName: MQTTX
uninstallDisplayName: MQTTX
createDesktopShortcut: always
oneClick: false
allowElevation: true
allowToChangeInstallationDirectory: true
createStartMenuShortcut: true

mac:
artifactName: ${productName}-${version}-${arch}.${ext}
Expand Down
2 changes: 1 addition & 1 deletion packages/ui/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export default defineConfig({
},
build: {
lib: {
entry: path.resolve(__dirname, '/src/index.ts'),
entry: path.resolve(__dirname, 'src/index.ts'),
name: '@mqttx/ui',
fileName: 'index',
formats: ['es'],
Expand Down