Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connection): the reconnect can only works on current page #1560

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

ysfscream
Copy link
Member

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

Reconnection will happen indefinitely.

Issue Number

Example: #1532 #1552

What is the new behavior?

Reconnection will only be maintained when on the current connecting page. If you leave the current connecting page, reconnection should be stopped immediately. This can solve many repetitive and meaningless reconnection prompts.

Please describe the new behavior or provide screenshots.

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

@ysfscream ysfscream added enhancement New feature or request fix Fix bug or issues desktop MQTTX Desktop labels Jan 16, 2024
@ysfscream ysfscream added this to the v1.9.9 milestone Jan 16, 2024
@ysfscream ysfscream self-assigned this Jan 16, 2024
@Red-Asuka Red-Asuka merged commit bdbc2c9 into main Jan 16, 2024
2 checks passed
@Red-Asuka Red-Asuka deleted the ysf/1.9/dev branch January 16, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop MQTTX Desktop enhancement New feature or request fix Fix bug or issues
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants