fix: prohibit the 'retry' and 'retry_timeout' opts #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the caller sets the `retry > 0` when starting the ehttpc, the down connections will be started by the underlying gun client periodically. So if one calls the health_check when `gun_state=down`, ehttpc will leak ports because it opens an new TCP connection, but the old connection was not closed. We forcely set `retry = 0`, and prohibit the user from setting the two opts: `retry` and `retry_timeout`.
terry-xiaoyu
force-pushed
the
no_retry
branch
2 times, most recently
from
34af25e
to
e8028b6
Compare
HJianBo
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the caller sets the
retry > 0when starting the ehttpc,the down connections will be started by the underlying gun client
periodically.
So if one calls the health_check when
gun_state=down,ehttpc will leak ports because it opens an new TCP connection, but
the old connection was not closed.
We forcely set
retry = 0, and prohibit the user from settingthe two opts:
retryandretry_timeout.