Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prohibit the 'retry' and 'retry_timeout' opts #34

Merged
merged 2 commits into from
Jul 27, 2022
Merged

fix: prohibit the 'retry' and 'retry_timeout' opts #34

merged 2 commits into from
Jul 27, 2022

Commits on Jul 27, 2022

  1. fix: prohibit the 'retry' and 'retry_timeout' opts 

    If the caller sets the `retry > 0` when starting the ehttpc,
the down connections will be started by the underlying gun client
periodically.

So if one calls the health_check when `gun_state=down`,
ehttpc will leak ports because it opens an new TCP connection, but
the old connection was not closed.

We forcely set `retry = 0`, and prohibit the user from setting
the two opts: `retry` and `retry_timeout`.
    @terry-xiaoyu
    terry-xiaoyu committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    6fcfc4b View commit details
    Browse the repository at this point in the history

  2. chore: bump to 0.3.0

    @terry-xiaoyu
    terry-xiaoyu committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    2ba4b8a View commit details
    Browse the repository at this point in the history