fix: retry request when error reason is normal
#45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thalesmg
force-pushed
the
fix-gun-down-normal-retry
branch
from
fc911b1
to
16ab83c
Compare
thalesmg
force-pushed
the
fix-gun-down-normal-retry
branch
from
16ab83c
to
bee3d7d
Compare
zmstone
approved these changes
Apr 21, 2023
HJianBo
approved these changes
Apr 21, 2023
8 tasks
thalesmg
added a commit
that referenced
this pull request
Apr 27, 2023
thalesmg
added a commit
that referenced
this pull request
Apr 27, 2023
thalesmg
added a commit
to thalesmg/emqx
that referenced
this pull request
Apr 27, 2023
Fixes https://emqx.atlassian.net/browse/EMQX-9656 See also emqx/ehttpc#45 This fixes a race condition where the remote server would close the connection before or during requests, and, depending on timing, an `{error, normal}` response would be returned. In those cases, we should just retry the request without using up "retry credits".
8 tasks
HJianBo
added a commit
to HJianBo/emqx
that referenced
this pull request
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://emqx.atlassian.net/browse/EMQX-9656