Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only perform "free" retry upon receiving DOWN signals #46

Closed
wants to merge 1 commit into from

Conversation

thalesmg
Copy link
Contributor

Addresses #45 (comment)

@thalesmg thalesmg marked this pull request as ready for review April 27, 2023 13:40
@thalesmg
Copy link
Contributor Author

Unfortunately, this leads to the return of the previous errors when there are lots of concurrent requests. Which means some cases are indeed from gun_down messages:

iex(emqx@127.0.0.1)8> 2023-04-27T13:58:24.867919-03:00 [error] msg: http_connector_do_request_failed, mfa: emqx_connector_http:on_query/3, line: 321, connector: <<"bridge:webhook:web">>, reason: normal, request: {"/api/batch_subscribe",[{<<"content-type">>,<<"application/json">>}],<<"{\n  \"clientid\": \"caribdis_bench_sub_1581851150_10829\"\n}">>}
2023-04-27T13:58:24.868215-03:00 [error] msg: unrecoverable_error, mfa: emqx_resource_buffer_worker:handle_query_result_pure/3, line: 823, id: <<"bridge:webhook:web">>, reason: normal

@thalesmg thalesmg closed this Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant