Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: running nodes should not include replica nodes #10313

Merged
merged 1 commit into from Apr 3, 2023

Conversation

JimMoen
Copy link
Member

@JimMoen JimMoen commented Apr 3, 2023

Fixes EMQX-9413

Summary

馃 Generated by Copilot at 53712e6

Fixed a cluster configuration issue and updated the emqx_conf application and change logs. The fix uses mria_mnesia:running_nodes to get cluster nodes and prevents copying cluster-override.conf from a replica node.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@JimMoen JimMoen requested a review from a team as a code owner April 3, 2023 12:01
@JimMoen
Copy link
Member Author

JimMoen commented Apr 3, 2023

It's a revert for part of changes in #7731

@JimMoen JimMoen merged commit 5b10937 into emqx:release-50 Apr 3, 2023
80 checks passed
@JimMoen JimMoen deleted the fix-cluster-node-selected branch April 3, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants