Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

0404 delay config change replay until handler is ready #10325

Conversation

zmstone
Copy link
Member

@zmstone zmstone commented Apr 4, 2023

Fixes https://emqx.atlassian.net/browse/EMQX-9457

this is a follow up fix for #10313 so there is no need for change logs.

Summary

馃 Generated by Copilot at 6401b7f

This pull request enhances the cluster RPC feature by upgrading the mria dependency, adding error handling and architecture detection to the buildx.sh script, renaming the emqx_cluster_rpc_handler module to emqx_cluster_rpc_cleaner, and restoring the workaround for the mria issue 94 in the emqx_conf_app module.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • [~] Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • [~] If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • [~] Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • [~] If changed package build workflow, pass this action (manual trigger)
  • [~] Change log has been added to changes/ dir for user-facing artifacts update

@zmstone zmstone force-pushed the 0404-delay-config-change-replay-until-handler-is-ready branch from 6401b7f to 8fd9dd7 Compare April 4, 2023 11:51
@zmstone zmstone closed this Apr 4, 2023
@zmstone zmstone reopened this Apr 4, 2023
ieQu1
ieQu1 previously approved these changes Apr 4, 2023
@zmstone zmstone marked this pull request as ready for review April 4, 2023 12:43
@zmstone zmstone requested a review from a team as a code owner April 4, 2023 12:43
thalesmg
thalesmg previously approved these changes Apr 4, 2023
scripts/buildx.sh Show resolved Hide resolved
@zmstone zmstone dismissed stale reviews from thalesmg and ieQu1 via 5925ff0 April 4, 2023 13:20
@zmstone zmstone merged commit 9e17064 into emqx:release-50 Apr 4, 2023
78 checks passed
@zmstone zmstone deleted the 0404-delay-config-change-replay-until-handler-is-ready branch April 4, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants