New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: copy cluster-override.conf from old version #10484
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
zhongwencool
force-pushed
the
fix-copy-conf
branch
from
April 23, 2023 10:06
fc90f8b
to
aa69f5d
Compare
zhongwencool
force-pushed
the
fix-copy-conf
branch
from
April 23, 2023 11:48
aa69f5d
to
6dcecfe
Compare
Pull Request Test Coverage Report for Build 4783657330
馃挍 - Coveralls |
zmstone
reviewed
Apr 23, 2023
zhongwencool
force-pushed
the
fix-copy-conf
branch
from
April 24, 2023 07:31
79fd30b
to
db0c951
Compare
zmstone
approved these changes
Apr 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Writeoff for merge without test case.
Please make sure that:
- The change has been tested (manually?)
- There is a follow up task to add test case.
follow up task: https://emqx.atlassian.net/browse/EMQX-9690 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10474
EMQX-9680
Previously, when we copied the initial configuration from an old node, if there was no 'has_deprecated_file' field, we treated it as a new mechanism using
cluster.hocon
. However, the old node never returned thehas_deprecated_file'
field before upgrading (due to a problem with the old code), so during rolling upgrade, it was always assumed thatcluster.hocon
was in effect when it should have beencluster-override.conf
.It's hard to write rolling upgrade CT test. I have verify on
v5.0.21
andv5.0.23
Summary
馃 Generated by Copilot at 7af9c18
Improved cluster configuration synchronization for mixed-version nodes. Refactored
emqx_conf_app.erl
and bumpedemqx_conf
version to 0.1.18.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md
filesChecklist for CI (.github/workflows) changes
changes/
dir for user-facing artifacts update