Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: don't do rpc call to check deprecated file #10505

Merged
merged 3 commits into from Apr 25, 2023

Conversation

zhongwencool
Copy link
Member

@zhongwencool zhongwencool commented Apr 25, 2023

Port(cherry-pick) #10484 's last commit to e5.0.3

Fixes: Update config crash when the cluster-override.conf is exist(don't need changlog, this behaviour is not release yet).
image

Summary

copilot:summary

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Changed lines covered in coverage report
  • Change log has been added to changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@zhongwencool zhongwencool requested review from a team and lafirest as code owners April 25, 2023 02:12
@zhongwencool zhongwencool merged commit 1b30dca into emqx:release-50 Apr 25, 2023
89 of 90 checks passed
@zhongwencool zhongwencool deleted the port-10484-to-release-50 branch April 25, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants