0517 fix bridge update timeout issue #10755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmstone
force-pushed
the
0517-fix-bridge-update-timeout-issue
branch
3 times, most recently
from
53ffa28
to
ad8550e
Compare
ieQu1
previously approved these changes
May 19, 2023
connect failure should be at warning level but not error, the connecting state is visiable from dashbaord also the resource manager logs connection failures in general at warning level
the timeout shutdown in child spec may significantly slow down the deletion of a resource this commit chagnes the shutdown to brutal kill also, the pool worker removal code has been delete because it's not necessary since the entier pool is going to be force-delete later anyway
the shutdown timeout is now set to infinity so it will never force kill a resource manager, otherwise there will be resource leaks
Update is implemented as remove + create. If a dleete call is made while the create is in progress the remove call is likely to timeout too. This causes the follwing creation to falsely succeed, because there is alreay a running child under the supervisor. As a result, the resource is permanently removed after resource_manager eventually handles the remove call.
zmstone
force-pushed
the
0517-fix-bridge-update-timeout-issue
branch
from
ad8550e
to
f4aa780
Compare
thalesmg
previously approved these changes
May 19, 2023
zmstone
force-pushed
the
0517-fix-bridge-update-timeout-issue
branch
from
f4aa780
to
cb76e5a
Compare
thalesmg
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://emqx.atlassian.net/browse/EMQX-9873
Summary
馃 Generated by Copilot at 53ffa28
This pull request improves the
emqx_connectorandemqx_resourceapplications by enhancing the performance, resource usage, error handling, and logging of the connector and the resource manager. It also fixes a bug in thedevscript and adds a new feature of dynamic resource creation and deletion based on the connector configuration. It updates the version number and the changelog accordingly.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update