Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0517 fix bridge update timeout issue #10755

Merged
merged 7 commits into from
May 20, 2023
Merged

0517 fix bridge update timeout issue #10755

merged 7 commits into from
May 20, 2023

Commits on May 19, 2023

  1. test: make erlfmt happy

    @zmstone
    zmstone committed May 19, 2023
    Configuration menu
    Copy the full SHA
    7eef863 View commit details
    Browse the repository at this point in the history

  2. fix(mqtt-connector): faster shutdown

    @zmstone
    zmstone committed May 19, 2023
    Configuration menu
    Copy the full SHA
    5bbcf4b View commit details
    Browse the repository at this point in the history

  3. chore(mqtt-connector): refine logging level 

    connect failure should be at warning level but not error,
the connecting state is visiable from dashbaord
also the resource manager logs connection failures in general
at warning level
    @zmstone
    zmstone committed May 19, 2023
    Configuration menu
    Copy the full SHA
    be90c63 View commit details
    Browse the repository at this point in the history

  4. fix(buffer-worker-sup): fast stop 

    the timeout shutdown in child spec may
significantly slow down the deletion of a resource

this commit chagnes the shutdown to brutal kill

also, the pool worker removal code has been delete
because it's not necessary since the entier pool is
going to be force-delete later anyway
    @zmstone
    zmstone committed May 19, 2023
    Configuration menu
    Copy the full SHA
    21de0f8 View commit details
    Browse the repository at this point in the history

  5. refactor(resource-manager-sup): do not force kill resource manager 

    the shutdown timeout is now set to infinity so it will never
force kill a resource manager, otherwise there will be
resource leaks
    @zmstone
    zmstone committed May 19, 2023
    Configuration menu
    Copy the full SHA
    f5e5c59 View commit details
    Browse the repository at this point in the history

  6. fix(resource-manager): ensure no false creation 

    Update is implemented as remove + create.
If a dleete call is made while the create is in progress
the remove call is likely to timeout too.

This causes the follwing creation to falsely succeed,
because there is alreay a running child under the supervisor.

As a result, the resource is permanently removed after
resource_manager eventually handles the remove call.
    @zmstone
    zmstone committed May 19, 2023
    Configuration menu
    Copy the full SHA
    0d8ffc0 View commit details
    Browse the repository at this point in the history

  7. docs: add changelog for 10755

    @zmstone
    zmstone committed May 19, 2023
    Configuration menu
    Copy the full SHA
    cb76e5a View commit details
    Browse the repository at this point in the history