New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mongodb): hide topology.pool_size
and fix it at 1
#11163
Merged
thalesmg
merged 1 commit into
emqx:master
from
thalesmg:fix-rm-mongo-topology-pool-size
Jun 30, 2023
Merged
fix(mongodb): hide topology.pool_size
and fix it at 1
#11163
thalesmg
merged 1 commit into
emqx:master
from
thalesmg:fix-rm-mongo-topology-pool-size
Jun 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thalesmg
force-pushed
the
fix-rm-mongo-topology-pool-size
branch
2 times, most recently
from
June 29, 2023 18:56
d26571f
to
ea4ab00
Compare
thalesmg
added a commit
to thalesmg/emqx-dashboard5
that referenced
this pull request
Jun 29, 2023
Will require changes in the frontend. Attempt PR: emqx/emqx-dashboard5#1568 |
thalesmg
force-pushed
the
fix-rm-mongo-topology-pool-size
branch
from
June 29, 2023 19:16
ea4ab00
to
fec1233
Compare
Pull Request Test Coverage Report for Build 5423344081
馃挍 - Coveralls |
keynslug
reviewed
Jun 30, 2023
Fixes https://emqx.atlassian.net/browse/EMQX-10408 From an old conversation with @kjellwinblad: > There are 3 pool_sizes > - The buffer workers pool size, just exposed here: emqx#9742 > - The topology.pool_size, which controls the pool size for the poolboy_pool in Kjell's diagram (on mongodb's side). > - The pool_size from emqx_connector_mongo:mongo_fields that controls the ecpool pool size (on EMQX's side). > So we actually want to set topology.pool_size = 1 and hide it from users.
thalesmg
force-pushed
the
fix-rm-mongo-topology-pool-size
branch
from
June 30, 2023 13:17
fec1233
to
3c8f591
Compare
keynslug
approved these changes
Jun 30, 2023
paulozulato
approved these changes
Jun 30, 2023
ieQu1
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://emqx.atlassian.net/browse/EMQX-10408
From an old conversation with @kjellwinblad:
Summary
馃 Generated by Copilot at 40aecf4
Hide
pool_size
option and set it to 1 for MongoDB plugin. This avoids confusion and improves compatibility with the MongoDB driver.PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/{ce,ee}/(feat|perf|fix)-<PR-id>.en.md
filesChecklist for CI (.github/workflows) changes
changes/
dir for user-facing artifacts update