feat(mongo): expose buffer worker opts to the bridge frontend (5.0) #9742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thalesmg
force-pushed
the
expose-resource-opts-mongo-v50
branch
2 times, most recently
from
769de36
to
ed9b647
Compare
zmstone
reviewed
Jan 12, 2023
| lists:map( | ||
| fun | ||
| ({query_mode, FieldSchema0}) -> | ||
| FieldSchema = FieldSchema0#{default => sync}, |
There was a problem hiding this comment.
maybe just hoconsc:mk/2 a new one instead of manipulating an opaque term.
There was a problem hiding this comment.
Ok, I'll do that.
But it feels dangerous that it's quite easy for the "upstream" type to change and then this new version will get out of date. 🙊
thalesmg
force-pushed
the
expose-resource-opts-mongo-v50
branch
from
ed9b647
to
e776dd1
Compare
thalesmg
force-pushed
the
expose-resource-opts-mongo-v50
branch
from
e776dd1
to
ed2be4d
Compare
k32
approved these changes
Jan 13, 2023
ieQu1
approved these changes
Jan 13, 2023
ieQu1
approved these changes
Jan 13, 2023
3 tasks
thalesmg
added a commit
to thalesmg/emqx
that referenced
this pull request
Jun 30, 2023
Fixes https://emqx.atlassian.net/browse/EMQX-10408 From an old conversation with @kjellwinblad: > There are 3 pool_sizes > - The buffer workers pool size, just exposed here: emqx#9742 > - The topology.pool_size, which controls the pool size for the poolboy_pool in Kjell's diagram (on mongodb's side). > - The pool_size from emqx_connector_mongo:mongo_fields that controls the ecpool pool size (on EMQX's side). > So we actually want to set topology.pool_size = 1 and hide it from users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.