fix(gw): use more conservative set of DTLS options #12180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keynslug
force-pushed
the
fix/gw-dtls-opts
branch
from
1787eec
to
5b9a6ec
Compare
id
reviewed
Dec 15, 2023
id
previously approved these changes
Dec 18, 2023
HJianBo
previously approved these changes
Dec 19, 2023
Currently, only certificate issuing and related utilities are there.
Thus ensuring full backward compatibility. Unsupported options (`gc_after_handshake`, `ocsp`) are silently ignored now. Also make sure that UDP configuration are part of DTLS option set, as expected by `esockd`.
keynslug
force-pushed
the
fix/gw-dtls-opts
branch
from
1e2af5c
to
609fac0
Compare
keynslug
commented
Dec 20, 2023
Comment on lines
+21
to
+24
| -export([gen_cert/1]). | ||
| -export([write_cert/2]). | ||
| -export([write_cert/3]). | ||
| -export([write_pem/2]). |
There was a problem hiding this comment.
Too late I found out about emqx_common_test_helpers:gen_ca/2 and friends. 😓
Also drop unnecessary UDP default options.
keynslug
force-pushed
the
fix/gw-dtls-opts
branch
from
7fbd022
to
bc38cdb
Compare
Also separate DTLS related MQTT-SN test config, so that it doesn't leak into this test suite.
keynslug
force-pushed
the
fix/gw-dtls-opts
branch
from
bc38cdb
to
ccb9a97
Compare
zmstone
approved these changes
Dec 20, 2023
This was referenced Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release version: v5.4
Summary
Exclude some options from the gateway listener DTLS options that have been breaking listener startup, even while being undefined in the config.
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
Added property-based tests for code which performs user input validationchanges/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfilesCreated PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket