Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0308 load cluster hocon to generate app.config #12672

Merged

Conversation

zmstone
Copy link
Member

@zmstone zmstone commented Mar 8, 2024

Fixes EMQX-10893

Release version: v/e5.6.0

Summary

Prior to this change, cluster.hocon was not loaded to generate app.<time>.config,
because it might change after boot.
This behavior lead to an issue for logging behaviour since logger has to be configured before the node boot.

PR Checklist

Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:

  • Added tests for the changes
  • Added property-based tests for code which performs user input validation
  • Changed lines covered in coverage report
  • Change log has been added to changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.md files
  • For internal contributor: there is a jira ticket to track this change
  • Created PR to emqx-docs if documentation update is required, or link to a follow-up jira ticket
  • Schema changes are backward compatible

Checklist for CI (.github/workflows) changes

  • If changed package build workflow, pass this action (manual trigger)
  • Change log has been added to changes/ dir for user-facing artifacts update

@zmstone zmstone requested a review from a team as a code owner March 8, 2024 11:20
thalesmg
thalesmg previously approved these changes Mar 8, 2024
Copy link
Contributor

@thalesmg thalesmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: should this take into account legacy cluster-override.conf files as well?

@zmstone zmstone force-pushed the 0308-load-cluster-hocon-to-generate-app.config branch from 294a3f7 to 73af8af Compare March 8, 2024 14:15
@zmstone
Copy link
Member Author

zmstone commented Mar 8, 2024

Q: should this take into account legacy cluster-override.conf files as well?

no, it's been quite long since the deprecation
this only affects log configs all other configs are not intended in cluster*.{conf|hocon}

@zmstone zmstone force-pushed the 0308-load-cluster-hocon-to-generate-app.config branch from 73af8af to 62ebcd7 Compare March 8, 2024 14:27
@zhongwencool
Copy link
Member

It works!

@zmstone zmstone merged commit a00ce8f into emqx:release-56 Mar 13, 2024
166 checks passed
@zmstone zmstone deleted the 0308-load-cluster-hocon-to-generate-app.config branch March 13, 2024 08:05
@zmstone zmstone mentioned this pull request Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants