0308 minor refactors #12674
Merged
0308 minor refactors #12674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmstone
force-pushed
the
0308-minor-refactors
branch
from
602e339
to
bec5ee8
Compare
Before the recent changes these testcases relied on the fact that peer nodes that are part of the test cluster are started one after the other. This is now not the case in general with `emqx_cth_cluster`, so now we need to additionally find the "longest running node" in the cluster before running test logic.
lists:join is now available in all supported OTP versions
zmstone
force-pushed
the
0308-minor-refactors
branch
from
fe424d6
to
99e7840
Compare
zmstone
requested review from
ieQu1,
keynslug,
kjellwinblad,
lafirest and
JimMoen
as code owners
zmstone
force-pushed
the
0308-minor-refactors
branch
from
99e7840
to
9357e66
Compare
qzhuyan
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release: v/e5.6.0
Summary
release-56