refactor: introduce extra macro to be overridden in different repos #13713
+52
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
id
previously approved these changes
Aug 28, 2024
The idea is to only use this new macro for introducing extra schema modules that are idiosyncratic to the repo itself, thus avoiding missing some schema modules when overridding `?EE_SCHEMA_MODULES` as is done today.
thalesmg
force-pushed
the
20240828-r58-fix-ee-schema-mods
branch
from
ad169bf
to
d4b464f
Compare
id
approved these changes
Aug 28, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to only use this new macro for introducing extra schema modules that are idiosyncratic to the repo itself, thus avoiding missing some schema modules when overridding
?EE_SCHEMA_MODULESas is done today.Release version: e5.8.1
Summary
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
changes/(ce|ee)/(feat|perf|fix|breaking)-<PR-id>.en.mdfilesChecklist for CI (.github/workflows) changes
changes/dir for user-facing artifacts update