Introduce new bridge impl #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4867
💛 - Coveralls |
spring2maz
force-pushed
the
introduce-new-bridge-impl
branch
3 times, most recently
from
dbf388d
to
d866a97
Compare
spring2maz
force-pushed
the
introduce-new-bridge-impl
branch
from
2acc074
to
a381c61
Compare
gilbertwong96
suggested changes
Feb 19, 2019
gilbertwong96
approved these changes
Feb 19, 2019
spring2maz
force-pushed
the
introduce-new-bridge-impl
branch
from
f14f7fe
to
4b40e99
Compare
spring2maz
force-pushed
the
introduce-new-bridge-impl
branch
from
9dfdf5f
to
8d552ca
Compare
gilbertwong96
force-pushed
the
introduce-new-bridge-impl
branch
5 times, most recently
from
ce3a504
to
3aa7cbe
Compare
spring2maz
force-pushed
the
introduce-new-bridge-impl
branch
2 times, most recently
from
80c53c7
to
e363546
Compare
turtleDeng
reviewed
Feb 26, 2019
turtleDeng
reviewed
Feb 26, 2019
gilbertwong96
approved these changes
Feb 26, 2019
turtleDeng
approved these changes
Feb 27, 2019
gilbertwong96
force-pushed
the
introduce-new-bridge-impl
branch
from
0307f36
to
0fd689b
Compare
In this commit, msg_handler option is added to emqx_client.
so the caller can provide callbacks to handle puback, publish,
as well as disconnected events instead of always delivered
as message like Owner ! {publish, Msg} to the owner process.
This is to make it ready to implement emqx_portal_connect on
top of emqx_client.
also cover emqx_portal_mqtt with CT
bridge.$name.transport was added before we decided to derive transport portocol based on the 'address' config. i.e. when it's a remote erlang node, use gen_rpc otherwise (must be IP or hostnmae), we should estabilish mqtt connection
eqmx_portal_mqtt has to do single message publish calls for now Also fix a bug in emqx_portal_mqtt ack collector
gilbertwong96
force-pushed
the
introduce-new-bridge-impl
branch
from
cfc9b8f
to
d18f4ba
Compare
gilbertwong96
suggested changes
Feb 28, 2019
Makefile
Outdated
| @@ -35,7 +35,7 @@ CT_SUITES = emqx emqx_client emqx_zone emqx_banned emqx_session \ | |||
| emqx_keepalive emqx_lib emqx_metrics emqx_mod emqx_mod_sup emqx_mqtt_caps \ | |||
| emqx_mqtt_props emqx_mqueue emqx_net emqx_pqueue emqx_router emqx_sm \ | |||
| emqx_tables emqx_time emqx_topic emqx_trie emqx_vm emqx_mountpoint \ | |||
| emqx_listeners emqx_protocol emqx_pool emqx_shared_sub emqx_bridge \ | |||
| emqx_listeners emqx_protocol emqx_pool emqx_shared_sub emqx_portal \ | |||
There was a problem hiding this comment.
Use bridge rather portal
src/emqx_client.erl
Outdated
| when (QoS =:= ?QOS_1); (QoS =:= ?QOS_2) -> | ||
| case emqx_inflight:is_full(Inflight) of | ||
| true -> | ||
| when (QoS =:= ?QOS_1); (QoS =:= ?QOS_2) -> |
gilbertwong96
approved these changes
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is still a work-in-progress PR.