fix(scripts): Finds node name and cookie from vm.args #4430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmstone
force-pushed
the
fix-scripts-find-node-name-and-cookie-from-vm.args
branch
from
7dac223
to
25536ef
Compare
For node name and cookie overriden from environment variable the only way to find it from another shell is to inspect the vm.args file. For node boot commands, the vm.args file may not have been created yet, so we need to inspect node name in emqx.conf
zmstone
force-pushed
the
fix-scripts-find-node-name-and-cookie-from-vm.args
branch
from
25536ef
to
c8c7186
Compare
zmstone
force-pushed
the
fix-scripts-find-node-name-and-cookie-from-vm.args
branch
from
4a2dde4
to
202a8cd
Compare
Rory-Z
reviewed
Mar 24, 2021
Rory-Z
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For node name and cookie overriden from environment variable
the only way to find it from another shell is to inspect
the vm.args file.
For node boot commands, the vm.args file may not have been created
yet, so we need to inspect node name in emqx.conf
Fixes
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/emqx/emqx/blob/master/CONTRIBUTING.md.
PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
Backward Compatibility
More information