New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format the listeners API fields #8571
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rory-Z
approved these changes
Jul 26, 2022
e.g: - Configured as `1883`, printed as `:1883` - Configured as `0.0.0.0:1883`, printed as `:1883` - Configured as `127.0.0.1:1883`, printed as `127.0.0.1:1883` - Configured as `::1:1883`, printed as `[::1]:1883` - Configured as `[::1]:1883`, printed as `[::1]:1883`
zhongwencool
approved these changes
Jul 27, 2022
HJianBo
added a commit
that referenced
this pull request
Aug 19, 2022
HJianBo
added a commit
to HJianBo/emqx
that referenced
this pull request
Sep 26, 2022
In the emqx#8571, we add a colon before the port. But it was not popular, so we removed ta in this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some an incompatible changes, but we had to fix the incorrect API formatting as soon as possible. A summary changes:
Using the standard
status
andnode_status
data format forGET /listeners
andGET /gateway/<name>/listeners
.Before this changes, the MQTT listener APIs returned these fields as:
The Gateway listener API returned as:
In this PR, we unify these fields both listeners API as:
Ensure the
bind
output style1883
, printed as:1883
0.0.0.0:1883
, printed as:1883
127.0.0.1:1883
, printed as127.0.0.1:1883
::1:1883
, printed as[::1]:1883
[::1]:1883
, printed as[::1]:1883
Move
running
field intostatus
andnode_status
field for Gateway listeners APIAdd
type
,name
fields for MQTT listeners API