Improve the ip_port() definition and bind print format
#9047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the emqx#8571, we add a colon before the port. But it was not popular, so we removed ta in this PR
zmstone
previously approved these changes
Sep 26, 2022
zmstone
previously approved these changes
Sep 27, 2022
Rory-Z
previously approved these changes
Sep 27, 2022
HJianBo
changed the title
ip_port() definition and bind print format
Rory-Z
approved these changes
Sep 28, 2022
ieQu1
approved these changes
Sep 28, 2022
zmstone
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the #8571, we add a colon before the port.
In this PR, we add some comments to explain how we made this decision. And get the following improvements.
0.0.0.0:1883and:::1883:1883before0.0.0.0:1883and[::]:1883emqx_schema:to_ip_port/1